roxen.lists.roxen.general

Subject Author Date
Re: HTTP compression Martin Jonsson <marty[at]roxen[dot]com> 05-05-2009
Stephen R. van den Berg wrote:
> No, I fixed another critical one.
> The current patch(set) still in use for my version is (the one in http.pike
> is the critical one (obviously)):
>
>
> diff --git a/server/protocols/http.pike b/server/protocols/http.pike
> index 3bff4f2..92c802b 100644
> --- a/server/protocols/http.pike
> +++ b/server/protocols/http.pike
> @@ -2368,7 +2368,7 @@ void send_result(mapping|void result)
>              if(compressed = 
>  	       try_gzip_data(data, variant_heads["Content-Type"])) {
>                data = compressed;
> -              file->encoding = encoding = "gzip";
> +              encoding = "gzip";
>              }
>            }
>  #endif
>   
Hmm, what is the patch supposed to fix?

Not setting file->encoding means that "encoding" will end up as 
undefined in the cache entry metadata mapping, which in turn makes the 
test around line 2969 to always fail when reusing a protcache entry. I 
guess that means that we will send gzipped responses to all clients, 
even those not announcing gzip capabilities..?

Regards,
Martin

-- 
Martin Jonsson	E-mail: <<marty[at]roxen.com>>
Developer       Cell:   +46-709-153931
Roxen Internet Software AB