roxen.lists.roxen.general

Subject Author Date
Re: [PATCH 14/17] New module: gzip-on-the-fly Stephen R. van den Berg <srb[at]cuci[dot]nl> 20-01-2009
Martin Stjernholm wrote:
>"Stephen R. van den Berg" <<srb[at]cuci.nl>> wrote:

>>  server/modules/filters/gziponthefly.pike |  102
++++++++++++++++++++++++++++++

>Just recently, Marty (cc'd) made an experimental patch to get
>compression directly in the http protocol. One reason to do that was
>to make it happen after the protocol module has fixed the charset
>encoding. Another is that it can be tied in with the protocol cache
>(it might not be wise to spend cpu on compressing dynamic answers).

>Maybe you can compare solutions?

Sure.  I'd be happy to review Marty's.
With respect to dynamic answers, there certainly is a point to
compressing them.  CPU is (again) getting cheaper than bandwidth these days.
Using a light compression factor you normally outrun the network and
don't use a lot of CPU.
My compressor singles out text/* content-types, it doesn't even try
for others (all others should be compressed already).

P.S. Any guidance on the usage of register_vary_callback ?
I looked at all the sample code in Roxen and Sitebuilder, all the docs,
and even at the source supposedly invoking the callbacks, but it's not
at all clear; especially with Arjan telling me I can use the callbacks
both on request and on result headers.  It seems to work for request
headers only.
-- 
Sincerely,
           Stephen R. van den Berg.

"Please, somebody give him a blowjob so we can impeach him."